Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove token_filter in _analyze API #20283

Closed
dadoonet opened this issue Sep 1, 2016 · 3 comments
Closed

Remove token_filter in _analyze API #20283

dadoonet opened this issue Sep 1, 2016 · 3 comments
Assignees
@johtani
Labels
>breaking :Search/Analysis How text is split into tokens

Comments

@dadoonet
Copy link
Member

dadoonet commented Sep 1, 2016

When you define an analyzer, we only support filter instead of token_filter. See https://www.elastic.co/guide/en/elasticsearch/reference/master/analysis-custom-analyzer.html

But the _analyze API still supports both forms. I suggest that we remove support for token_filter in _analyze API.

See also #17843.
@dadoonet dadoonet added discuss :Search/Analysis How text is split into tokens labels Sep 1, 2016
@dadoonet
Copy link
Member Author

dadoonet commented Sep 1, 2016

@johtani WDYT?

@johtani
Copy link
Contributor

johtani commented Sep 1, 2016

+1

@dadoonet dadoonet removed the discuss label Sep 1, 2016
@s1monw
Copy link
Contributor

s1monw commented Sep 1, 2016

++

johtani added a commit to johtani/elasticsearch that referenced this issue Sep 1, 2016
@johtani
Remove token_filter in _analyze API
3d9f8ed 
Remove the param and change docs

Closes elastic#20283
@johtani johtani mentioned this issue Sep 1, 2016
Merged
johtani added a commit to johtani/elasticsearch that referenced this issue Sep 2, 2016
@johtani
Remove token_filter in _analyze API
aef2e5d 
Fix wording in docs
Refactoring RestAnalyzeActionTests using expectThrows()

Closes elastic#20283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johtani johtani

Labels
>breaking :Search/Analysis How text is split into tokens
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clintongormley @dadoonet @s1monw @johtani