Give useful error message if log config is missing #20493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>enhancement
review
:Core/Infra/Logging
|
This provides: 21:43:57 ⌁ [jason:~] $ ~/elasticsearch/elasticsearch-6.0.0-alpha1-SNAPSHOT/bin/elasticsearch
ERROR: no log4j2.properties found; tried [/Users/jason/elasticsearch/elasticsearch-6.0.0-alpha1-SNAPSHOT/config] and its subdirectories
21:50:13 ⌁ [jason:~] 78 $ |
|
LGTM |
1 similar comment
|
LGTM |
Today when starting Elasticsearch without a Log4j 2 configuration file, we end up throwing an array index out of bounds exception. This is because we are passing no configuration files to Log4j. Instead, we should throw a useful error message to the user. This commit modifies the Log4j configuration setup to throw a user exception if no Log4j configuration files are present in the config directory.
jasontedor
added a commit
that referenced
this pull request
Sep 15, 2016
Today when starting Elasticsearch without a Log4j 2 configuration file, we end up throwing an array index out of bounds exception. This is because we are passing no configuration files to Log4j. Instead, we should throw a useful error message to the user. This commit modifies the Log4j configuration setup to throw a user exception if no Log4j configuration files are present in the config directory. Relates #20493
jasontedor
added a commit
that referenced
this pull request
Sep 15, 2016
Today when starting Elasticsearch without a Log4j 2 configuration file, we end up throwing an array index out of bounds exception. This is because we are passing no configuration files to Log4j. Instead, we should throw a useful error message to the user. This commit modifies the Log4j configuration setup to throw a user exception if no Log4j configuration files are present in the config directory. Relates #20493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when starting Elasticsearch without a Log4j 2 configuration file,
we end up throwing an array index out of bounds exception. This is
because we are passing no configuration files to Log4j. Instead, we
should throw a useful error message to the user. This commit modifies
the Log4j configuration setup to throw a user exception if no Log4j
configuration files are present in the config directory.