Prevent double release in TcpTransport if send listener throws an exception #20880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption today we might release a bytes array more than once if the send listener throws an execption but already has released the array. Yet, this is already fixed in the BytesArray class we use in production to ensure 3rd party users don't release twice but our mocks still enforce it.
s1monw
added
>bug
review
:Distributed/Network
bleskes
approved these changes
Oct 12, 2016
s1monw
added a commit
that referenced
this pull request
Oct 12, 2016
…eption (#20880) today we might release a bytes array more than once if the send listener throws an exception but already has released the array. Yet, this is already fixed in the BytesArray class we use in production to ensure 3rd party users don't release twice but our mocks still enforce it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today we might release a bytes array more than once if the send listener
throws an exception but already has released the array. Yet, this is already fixed
in the BytesArray class we use in production to ensure 3rd party users don't release
twice but our mocks still enforce it.
see this build for reference https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=debian/95/consoleFull