Add a REST spec for the create API #20924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The create request now requires that an ID be present. Currently the clients hard code a create method, but we should just add a create REST spec so this method can be autogenerated.
clintongormley
added
>enhancement
review
:Core/Infra/REST API
bleskes
approved these changes
Oct 13, 2016
| { | ||
| "create": { | ||
| "documentation": "http://www.elastic.co/guide/en/elasticsearch/reference/master/docs-index_.html", | ||
| "methods": ["PUT"], |
There was a problem hiding this comment.
we also except POST here in the java code. Not sure what the convention is though - do we want to be "correct" or reflect what he java does?
There was a problem hiding this comment.
I'll add POST, thanks for the review
|
/cc @elastic/es-clients |
clintongormley
added a commit
that referenced
this pull request
Oct 17, 2016
The create request now requires that an ID be present. Currently the clients hard code a create method, but we should just add a create REST spec so this method can be autogenerated.
clintongormley
added a commit
that referenced
this pull request
Oct 17, 2016
The create request now requires that an ID be present. Currently the clients hard code a create method, but we should just add a create REST spec so this method can be autogenerated.
clintongormley
added a commit
that referenced
this pull request
Oct 17, 2016
clintongormley
added a commit
that referenced
this pull request
Oct 17, 2016
clintongormley
added a commit
that referenced
this pull request
Oct 17, 2016
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 19, 2016
Now that the create api has its own spec, we can remove the special case in the yaml test client for it Relates to elastic#20924
javanna
added a commit
that referenced
this pull request
Oct 20, 2016
Now that the create api has its own spec, we can remove the special case in the yaml test client for it Relates to #20924
javanna
added a commit
that referenced
this pull request
Oct 20, 2016
Now that the create api has its own spec, we can remove the special case in the yaml test client for it Relates to #20924
javanna
added a commit
that referenced
this pull request
Oct 20, 2016
Now that the create api has its own spec, we can remove the special case in the yaml test client for it Relates to #20924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The create request now requires that an ID be present.
Currently the clients hard code a create method, but
we should just add a create REST spec so this method
can be autogenerated.