make painless the default scripting language for ScriptProcessor #20981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>bug
>docs
rjernst
reviewed
Oct 17, 2016
| @@ -80,7 +84,7 @@ public Factory(ScriptService scriptService) { | |||
| @Override | |||
| public ScriptProcessor create(Map<String, Processor.Factory> registry, String processorTag, | |||
| Map<String, Object> config) throws Exception { | |||
| String lang = readStringProperty(TYPE, processorTag, config, "lang"); | |||
| String lang = readStringProperty(TYPE, processorTag, config, "lang", "painless"); | |||
There was a problem hiding this comment.
Why is this hardcoded at all, and not just using the ScriptService and the default that is configured there?
There was a problem hiding this comment.
@rjernst simply because I was not aware there was such default behavior in the ScriptService. I will move defaulting responsibility to the ScriptService, will update. thanks!
martijnvg
approved these changes
Oct 18, 2016
| @@ -69,6 +69,10 @@ public String getType() { | |||
| return TYPE; | |||
| } | |||
|
|
|||
| public Script getScript() { | |||
There was a problem hiding this comment.
getter can be package protected?
- fixes a bug in the docs that mentions `lang` as optional - now `lang` defaults to "painless"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langas optionallangdefaults to "painless"Closes #20943.