Disallow VersionType.FORCE for GetRequest
#21079
Conversation
This doesn't make much sense to have at all, since a user can do a `GET` request without a version of they want to get it unconditionally. Relates to elastic#20995
dakrone
added
>breaking
:Distributed/CRUD
| @@ -101,6 +101,9 @@ public ActionRequestValidationException validate() { | |||
| validationException = ValidateActions.addValidationError("illegal version value [" + version + "] for version type [" + versionType.name() + "]", | |||
| validationException); | |||
| } | |||
| if (versionType == VersionType.FORCE) { | |||
There was a problem hiding this comment.
isn't this a problem if coming from an update request with force? should we do something there to enable this?
There was a problem hiding this comment.
I dunno, the more I think about this, more I think we should not have a hard check on this, with 6.0 it won't break anything on GET requests and I'm not sure the complexity is worth it, it can just be removed in 7.0 entirely.
What do you think?
There was a problem hiding this comment.
so to answer my own question - it's not a problem because the update request handling goes directly to the IndexShard - UpdateHelper#prepare(org.elasticsearch.action.update.UpdateRequest, org.elasticsearch.index.shard.IndexShard)
I think we should not have a hard check on this, with 6.0 it won't break anything on GET requests
I think this is still good to do? like we remove the FORCE support from other API in 6.0?
There was a problem hiding this comment.
Ahh okay, if the UpdateHelper doesn't use this then we should be able to block this with no problem.
clintongormley
changed the title
VersionType.FORCE for GetRequest
This doesn't make much sense to have at all, since a user can do a
GETrequest without a version of they want to get it unconditionally.
Relates to #20995