Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to bulk tasks #22059

Merged

Conversation

Projects
None yet
2 participants
@imotov
Copy link
Member

commented Dec 8, 2016

Related to #21768

@nik9000

nik9000 approved these changes Dec 8, 2016

core/src/main/java/org/elasticsearch/action/bulk/BulkRequest.java Outdated

@Override
public String getDescription() {
return "requests[" + requests.size() + "]" + ", indices[" + Strings.collectionToDelimitedString(indices, ", ") + "]";

This comment has been minimized.

Copy link
@nik9000

nik9000 Dec 8, 2016

Contributor

I think s/" + "//.

This comment has been minimized.

Copy link
@imotov

imotov Dec 8, 2016

Author Member

Good catch! Thanks!

@imotov imotov removed the v5.2.0 label Dec 8, 2016

@imotov

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2016

It looks like I will not be able to push it to 5.2.0 because it is relying on #20109, which isn't going to be backported.

@imotov imotov force-pushed the imotov:issue-21768-add-description-to-bulk-task branch to 7f79c99 Dec 9, 2016

@imotov imotov merged commit 7f79c99 into elastic:master Dec 9, 2016

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.