Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to bulk tasks #22059

Merged

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Dec 8, 2016

Related to #21768

@imotov imotov added :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. >enhancement review v5.2.0 v6.0.0-alpha1 labels Dec 8, 2016

@Override
public String getDescription() {
return "requests[" + requests.size() + "]" + ", indices[" + Strings.collectionToDelimitedString(indices, ", ") + "]";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think s/" + "//.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@imotov imotov removed the v5.2.0 label Dec 8, 2016
@imotov
Copy link
Contributor Author

imotov commented Dec 8, 2016

It looks like I will not be able to push it to 5.2.0 because it is relying on #20109, which isn't going to be backported.

@imotov imotov force-pushed the issue-21768-add-description-to-bulk-task branch from 2039628 to 7f79c99 Compare December 9, 2016 03:43
@imotov imotov merged commit 7f79c99 into elastic:master Dec 9, 2016
@imotov imotov deleted the issue-21768-add-description-to-bulk-task branch May 1, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. >enhancement v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants