Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote longs to doubles when a terms agg mixes decimal and non-decimal numbers #22449

Merged
merged 4 commits into from
Jan 10, 2017
Merged

Promote longs to doubles when a terms agg mixes decimal and non-decimal numbers #22449

merged 4 commits into from
Jan 10, 2017

Commits on Jan 10, 2017

  1. Promote longs to doubles when a terms agg mixes decimal and non-decim… 

    …al number

This change makes the terms aggregation work when the buckets coming from different indices are a mix of decimal numbers and non-decimal numbers. In this case non-decimal number (longs) are promoted to decimal (double) which can result in a loss of precision for big numbers.

Fixes #22232
    @jimczi
    jimczi committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    6ca5883 View commit details
    Browse the repository at this point in the history

  2. Restrict doubles conversion to RAW format and reuse the decimal forma… 

    …t for the conversion
    @jimczi
    jimczi committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    f1fe125 View commit details
    Browse the repository at this point in the history

  3. after review

    @jimczi
    jimczi committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    ef3405a View commit details
    Browse the repository at this point in the history

  4. Fix rest test

    @jimczi
    jimczi committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    33688c6 View commit details
    Browse the repository at this point in the history