Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Painless Loop Counter to be Higher #22560

Merged
merged 1 commit into from Jan 11, 2017

Conversation

Projects
None yet
3 participants
@jdconrad
Copy link
Contributor

commented Jan 11, 2017

Considering this a bug as it probably should have been higher to support updates in the first place, but still provides some infinite loop protection. Updated to 1000000 from 10000.

This counter applies on a loose basis to statements (not operations) within a loop in Painless. It is cumulative on a per function basis including the main function. Calls external to Painless functions count as one statement. This will hopefully become smarter in the future.

Relates: (#22508)

@nik9000
Copy link
Contributor

left a comment

Cool. I'd love to have the ability to control this context by context but until we get that, let's make this work properly in the update case.

@jdconrad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2017

@nik9000 Thanks for the review!

@jdconrad jdconrad merged commit 97c4cd4 into elastic:master Jan 11, 2017

0 of 3 checks passed

CLA Commit author has not signed the CLA and is not a member of Elasticsearch
Details
abs-temporary-test Build finished.
Details
elasticsearch-ci Build started sha1 is merged.
Details

jdconrad added a commit that referenced this pull request Jan 11, 2017

Update Painless Loop Counter to be Higher (#22560)
Updated Painless loop counter to be 1000000 statements instead of 10000 for update queries.

jdconrad added a commit that referenced this pull request Jan 11, 2017

Update Painless Loop Counter to be Higher (#22560)
Updated Painless loop counter to be 1000000 statements instead of 10000 for update queries.

jdconrad added a commit that referenced this pull request Jan 11, 2017

Update Painless Loop Counter to be Higher (#22560)
Updated Painless loop counter to be 1000000 statements instead of 10000 for update queries.

@nik9000 nik9000 added v5.1.3 and removed v5.1.2 labels Jan 12, 2017

@clintongormley clintongormley removed the v5.3.0 label Jan 23, 2017

@jdconrad jdconrad deleted the jdconrad:counter branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.