Update Painless Loop Counter to be Higher #22560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
approved these changes
Jan 11, 2017
|
@nik9000 Thanks for the review! |
jdconrad
added a commit
that referenced
this pull request
Jan 11, 2017
Updated Painless loop counter to be 1000000 statements instead of 10000 for update queries.
jdconrad
added a commit
that referenced
this pull request
Jan 11, 2017
Updated Painless loop counter to be 1000000 statements instead of 10000 for update queries.
jdconrad
added a commit
that referenced
this pull request
Jan 11, 2017
Updated Painless loop counter to be 1000000 statements instead of 10000 for update queries.
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering this a bug as it probably should have been higher to support updates in the first place, but still provides some infinite loop protection. Updated to 1000000 from 10000.
This counter applies on a loose basis to statements (not operations) within a loop in Painless. It is cumulative on a per function basis including the main function. Calls external to Painless functions count as one statement. This will hopefully become smarter in the future.
Relates: (#22508)