New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tika-files.zip by a tika-files dir #22963

Merged
merged 2 commits into from Feb 16, 2017

Conversation

Projects
None yet
3 participants
@dadoonet
Member

dadoonet commented Feb 3, 2017

Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

Replace tika-files.zip by a tika-files dir
Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

@dadoonet dadoonet self-assigned this Feb 3, 2017

@dadoonet dadoonet requested a review from nik9000 Feb 3, 2017

@dadoonet

This comment has been minimized.

Member

dadoonet commented Feb 16, 2017

@nik9000 ping. Could you look at this one please?
I'm planning to apply it to the same branches as we will have to apply #23214

@dadoonet dadoonet merged commit 19e59e1 into elastic:5.x Feb 16, 2017

1 check passed

CLA Commit author is a member of Elasticsearch
Details
@dadoonet

This comment has been minimized.

Member

dadoonet commented Feb 16, 2017

Thanks @nik9000!

@dadoonet dadoonet deleted the dadoonet:pr/22959-mapper-attachments branch Feb 16, 2017

@dadoonet dadoonet removed the v5.2.2 label Feb 16, 2017

dadoonet added a commit that referenced this pull request Feb 16, 2017

Replace tika-files.zip by a tika-files dir
Backport of #22963 in 5.3 branch

@dadoonet dadoonet added the v5.2.2 label Feb 20, 2017

dadoonet added a commit that referenced this pull request Feb 20, 2017

Replace tika-files.zip by a tika-files dir
Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

Backport of #22963 in 5.2 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment