Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tika-files.zip by a tika-files dir #22963

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

dadoonet
Copy link
Member

@dadoonet dadoonet commented Feb 3, 2017

Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to elastic#22958.
Same as of elastic#22959 but for mapper-attachments plugin
@dadoonet dadoonet added :Plugin Mapper Attachment >test Issues or PRs that are addressing/adding tests v5.3.0 labels Feb 3, 2017
@dadoonet dadoonet self-assigned this Feb 3, 2017
@dadoonet dadoonet requested a review from nik9000 February 3, 2017 15:45
@dadoonet
Copy link
Member Author

dadoonet commented Feb 16, 2017

@nik9000 ping. Could you look at this one please?
I'm planning to apply it to the same branches as we will have to apply #23214

@dadoonet dadoonet merged commit 19e59e1 into elastic:5.x Feb 16, 2017
@dadoonet
Copy link
Member Author

Thanks @nik9000!

@dadoonet dadoonet deleted the pr/22959-mapper-attachments branch February 16, 2017 16:51
@dadoonet dadoonet removed the v5.2.2 label Feb 16, 2017
dadoonet added a commit that referenced this pull request Feb 16, 2017
dadoonet added a commit that referenced this pull request Feb 20, 2017
Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

Backport of #22963 in 5.2 branch
@clintongormley clintongormley added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed :Plugin Mapper Attachment labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types >test Issues or PRs that are addressing/adding tests v5.2.2 v5.3.0 v5.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants