RestClient asynchronous execution should not throw exceptions #23307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of RestClient.performAsync() methods can throw exceptions before the request is asynchronously executed. Since it only throws unchecked exceptions, it's easy for the user/dev to forget to catch them. Instead I think async methods should never throw exceptions and should always call the listener onFailure() method.
tlrx
added
:Clients/Java Low Level REST Client
javanna
approved these changes
Feb 22, 2017
| new HttpHost[]{new HttpHost("localhost", 9200)}, null, null); | ||
| } | ||
|
|
||
| class TestListener implements ResponseListener { |
There was a problem hiding this comment.
I think you can use RestClient.SyncResponseListener here instead
|
I marked it as a bug, I think we should backport it too. |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
The current implementation of RestClient.performAsync() methods can throw exceptions before the request is asynchronously executed. Since it only throws unchecked exceptions, it's easy for the user/dev to forget to catch them. Instead I think async methods should never throw exceptions and should always call the listener onFailure() method.
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
The current implementation of RestClient.performAsync() methods can throw exceptions before the request is asynchronously executed. Since it only throws unchecked exceptions, it's easy for the user/dev to forget to catch them. Instead I think async methods should never throw exceptions and should always call the listener onFailure() method.
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
The current implementation of RestClient.performAsync() methods can throw exceptions before the request is asynchronously executed. Since it only throws unchecked exceptions, it's easy for the user/dev to forget to catch them. Instead I think async methods should never throw exceptions and should always call the listener onFailure() method.
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
With #23307, the expected exception is wrapped two times into a RuntimeException instead of being thrown directly.
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
With #23307, the expected exception is wrapped two times into a RuntimeException instead of being thrown directly.
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
With #23307, the expected exception is wrapped two times into a RuntimeException instead of being thrown directly.
tlrx
added a commit
that referenced
this pull request
Feb 28, 2017
With #23307, the expected exception is wrapped two times into a RuntimeException instead of being thrown directly.
|
Removing 5.2.2 label as this issue has not been packaged with 5.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
RestClient.performAsync()methods can throw exceptions before the request is asynchronously executed. Since it only throws unchecked exceptions, it's easy for the user/dev to forget to catch them, leaving the listener in the wild... Instead I think async methods should never throw exceptions and should always call the listener onFailure() method.