Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestClient asynchronous execution should not throw exceptions #23307

Merged
merged 2 commits into from
Feb 28, 2017
Merged

RestClient asynchronous execution should not throw exceptions #23307

merged 2 commits into from
Feb 28, 2017

Commits on Feb 22, 2017

  1. RestClient asynchronous execution should not throw exception 

    The current implementation of RestClient.performAsync() methods can throw exceptions before the request is asynchronously executed. Since it only throws unchecked exceptions, it's easy for the user/dev to forget to catch them. Instead I think async methods should never throw exceptions and should always call the listener onFailure() method.
    @tlrx
    tlrx committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    4fec1dc View commit details
    Browse the repository at this point in the history

  2. Use RestClient.SyncResponseListener

    @tlrx
    tlrx committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    93c4858 View commit details
    Browse the repository at this point in the history