Lazy load the geoip databases #23337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
reviewed
Feb 23, 2017
|
|
||
| private final String databaseFileName; | ||
| private final CheckedSupplier<DatabaseReader, IOException> loader; | ||
| DatabaseReader databaseReader; |
talevy
added
the
:Data Management/Ingest Node
rjernst
approved these changes
Feb 23, 2017
|
|
||
| private final String databaseFileName; | ||
| private final CheckedSupplier<DatabaseReader, IOException> loader; | ||
| final SetOnce<DatabaseReader> databaseReader; |
There was a problem hiding this comment.
please add a comment that it is package private to allow for testing.
martijnvg
force-pushed
the
lazy_load_geoip_database
branch
2 times, most recently
from
0d1d130
to
36bdbce
Compare
Load the geoip database the first time a pipeline gets created that has a geoip processor. This saves memory (measured ~150MB for the city db) in cases when the plugin is installed, but not used.
martijnvg
force-pushed
the
lazy_load_geoip_database
branch
from
36bdbce
to
211d50f
Compare
clintongormley
added
:Data Management/Ingest Node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load the geoip database the first time a pipeline gets created that has a geoip processor.
This saves memory (measured ~150MB for the city db) in cases when the plugin is installed, but not used.