-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify permissions dialog for plugins #23742
Modify permissions dialog for plugins #23742
Conversation
This commit modifies the handling of plugins that require special permissions to cover a case that was not previously covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left two minor nits.
spawnNativePluginController(spawnPath, environment.tmpFile()); | ||
} | ||
void spawnNativePluginControllers(final Environment environment) throws IOException { | ||
if (!spawned.compareAndSet(false, true)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see those C tendencies, and digust for == false
, creeping back in. :)
import java.nio.file.Path; | ||
import java.util.Locale; | ||
|
||
public class Plugins { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a different name, so that this is not one character off from the Plugin
class?
This commit modifies the handling of plugins that require special permissions to cover a case that was not previously covered. Relates #23742
This commit modifies the handling of plugins that require special permissions to cover a case that was not previously covered.