Modify permissions dialog for plugins #23742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the handling of plugins that require special permissions to cover a case that was not previously covered.
jasontedor
added
:Core/Infra/Plugins
rjernst
approved these changes
Mar 27, 2017
| spawnNativePluginController(spawnPath, environment.tmpFile()); | ||
| } | ||
| void spawnNativePluginControllers(final Environment environment) throws IOException { | ||
| if (!spawned.compareAndSet(false, true)) { |
There was a problem hiding this comment.
I see those C tendencies, and digust for == false, creeping back in. :)
| import java.nio.file.Path; | ||
| import java.util.Locale; | ||
|
|
||
| public class Plugins { |
There was a problem hiding this comment.
Can we use a different name, so that this is not one character off from the Plugin class?
jasontedor
added a commit
that referenced
this pull request
Mar 27, 2017
This commit modifies the handling of plugins that require special permissions to cover a case that was not previously covered. Relates #23742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the handling of plugins that require special permissions to cover a case that was not previously covered.