Move aggs CommonFields and TYPED_KEYS_DELIMITER from InternalAggregation to Aggregation #23987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
:Analytics/Aggregations
javanna
changed the title
…ion to Aggregation These will be shared between internal objects and objects exposed through high level REST client, so they should be moved from internal classes.
javanna
force-pushed
the
enhancement/move_common_fields_aggs
branch
from
e26a45b
to
087e4c7
Compare
javanna
added a commit
that referenced
this pull request
Apr 10, 2017
…ion to Aggregation (#23987) These will be shared between internal objects and objects exposed through high level REST client, so they should be moved from internal classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be shared between internal objects and objects exposed through high level REST client, so they should be moved from internal classes.