Move getProperty method out of MultiBucketsAggregation.Bucket interface #23988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
:Analytics/Aggregations
javanna
force-pushed
the
enhancement/bucket_get_prop_internal
branch
from
a662b95
to
e4f9025
Compare
The getProperty method is an internal method needed to run pipeline aggregations and retrieve info by path from the aggs tree. It is not needed in the MultiBucketsAggregation.Bucket interface, which is returned to users running aggregations from the transport client. The method is moved to the InternalMultiBucketAggregation class as that's where it belongs.
javanna
force-pushed
the
enhancement/bucket_get_prop_internal
branch
from
e4f9025
to
70dcf39
Compare
javanna
added a commit
that referenced
this pull request
Apr 10, 2017
…ce (#23988) The getProperty method is an internal method needed to run pipeline aggregations and retrieve info by path from the aggs tree. It is not needed in the MultiBucketsAggregation.Bucket interface, which is returned to users running aggregations from the transport client. The method is moved to the InternalMultiBucketAggregation class as that's where it belongs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getPropertymethod is an internal method needed to run pipeline aggregations and retrieve info by path from the aggs tree. It is not needed in theMultiBucketsAggregation.Bucketinterface, which is returned to users running aggregations from the transport client. The method is moved to theInternalMultiBucketAggregationclass as that's where it belongs.