Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix memory leak when percolator uses bitset or field data cache #24115
The percolator doesn't close the IndexReader of the memory index any more.
I think an alternative way to fix this is to let percolator not use the bitset and fielddata caches,
Adding a WIP label to this as I'm not happy with the current test. It is not easy to test that we don't use the bitset or fielddata cache for the percolator, because non percolator operations may use these caches, which is valid.
PR for #24108
Thanks for looking into it, I think what you are suggesting would work, we just need to make the wiring a bit nicer?
I've reverted this PR back to the initial approach (replacing field data and bitset cache in a custom