Add qa module that tests reindex-from-remote against pre-5.0 versions of Elasticsearch #24561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for reindex-from-remote for the latest 2.4, 1.7, and 0.90 releases. 2.4 and 1.7 are fairly popular versions but 0.90 is a point of pride. This fixes any issues those tests revealed. Closes elastic#23828 Closes elastic#24520
nik9000
commented
May 9, 2017
| * required for versions of Elasticsearch before 5.0 because they do not support | ||
| * writing a "ports" file. | ||
| */ | ||
| public class OldElasticsearch { |
There was a problem hiding this comment.
I'm not super comfortable with the degree of paranoia this has to leaving processes behind but I'm not sure that we can get much better from ES because it won't kill itself when stdin is closed.
In the interest to get 5.4.1 moving along I'll merge this now but I'd be happy to work on followups. |
nik9000
added a commit
that referenced
this pull request
May 11, 2017
nik9000
added a commit
that referenced
this pull request
May 11, 2017
nik9000
added a commit
that referenced
this pull request
May 11, 2017
nik9000
added a commit
that referenced
this pull request
May 11, 2017
I broke this in #24561 by adding additional randomization to the generated time values. They used to not generate units smaller than millis and that skipped testing many things. In this case ttl doesn't support units smaller than millis so we have to rework the test.
nik9000
added a commit
that referenced
this pull request
May 11, 2017
I broke this in #24561 by adding additional randomization to the generated time values. They used to not generate units smaller than millis and that skipped testing many things. In this case ttl doesn't support units smaller than millis so we have to rework the test.
nik9000
added a commit
that referenced
this pull request
May 11, 2017
Two of the versions of Elasticsearch we need to run for these tests can't run in Java 9 so we skip the entire test if we are running in java 9. For now. I'd like to reenable it to run against java 8 if there is one available, but that can wait for another time. Relates to #24561
nik9000
added a commit
that referenced
this pull request
May 11, 2017
Two of the versions of Elasticsearch we need to run for these tests can't run in Java 9 so we skip the entire test if we are running in java 9. For now. I'd like to reenable it to run against java 8 if there is one available, but that can wait for another time. Relates to #24561
nik9000
added a commit
that referenced
this pull request
May 11, 2017
Two of the versions of Elasticsearch we need to run for these tests can't run in Java 9 so we skip the entire test if we are running in java 9. For now. I'd like to reenable it to run against java 8 if there is one available, but that can wait for another time. Relates to #24561
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for reindex-from-remote for the latest 2.4, 1.7, and
0.90 releases. 2.4 and 1.7 are fairly popular versions but 0.90
is a point of pride.
This fixes any issues those tests revealed.
Closes #23828
Closes #24520