Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (deprecated) support for '+' in index expressions #25274

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Remove (deprecated) support for '+' in index expressions #25274

merged 1 commit into from
Jun 19, 2017

Conversation

javanna
Copy link
Member

@javanna javanna commented Jun 16, 2017

Relates to #24515

@javanna javanna added :Data Management/Indices APIs APIs to create and manage indices and templates >breaking review v6.0.0 labels Jun 16, 2017
@dakrone dakrone self-requested a review June 16, 2017 17:26
@dakrone dakrone removed their assignment Jun 16, 2017
dakrone
dakrone approved these changes Jun 16, 2017
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, thanks @javanna!

@javanna
Copy link
Member Author

javanna commented Jun 19, 2017

retest this please

@javanna javanna force-pushed the enhancement/remove_plus_index branch from 792e443 to 5dca3f4 Compare June 19, 2017 09:12
@olcbean
Copy link
Contributor

olcbean commented Jun 19, 2017

Hey @javanna, looks like this change is addressing #5341 as well. Or is there another usecase in which '+' should be supported in the path?

@javanna
Copy link
Member Author

javanna commented Jun 19, 2017

hi @olcbean '+' is still a valid character in index and alias names, just not in their first character. So I'm afraid #5341 is still a valid issue.

@javanna javanna merged commit d9ec2a2 into elastic:master Jun 19, 2017
@jkakavas jkakavas mentioned this pull request Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
>breaking :Data Management/Indices APIs APIs to create and manage indices and templates v6.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javanna @olcbean @dakrone @clintongormley