Remove default path settings #25408
Merged
Remove default path settings #25408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the default path settings for data and logs. With this change, we now ship the packages with these settings set in the elasticsearch.yml configuration file rather than going through the default.path.data and default.path.logs dance that we went through in the past.
jasontedor
added
:Delivery/Packaging
2 tasks
rjernst
approved these changes
Jun 26, 2017
| ==== Default path settings are removed | ||
|
|
||
| Previous versions of Elasticsearch enabled setting `default.path.data` and | ||
| `default.path.logs` so set the default data path and default logs path if they |
| @@ -35,8 +35,6 @@ fi | |||
| ES_HOME="/usr/share/elasticsearch" | |||
| MAX_OPEN_FILES=65536 | |||
| MAX_MAP_COUNT=262144 | |||
| LOG_DIR="/var/log/elasticsearch" | |||
There was a problem hiding this comment.
Should we fail hard if these env vars are set? Not sure where the appropriate place to check it is. Somewhere in the service files?
There was a problem hiding this comment.
That would be the only place, these environment variables were only ever used in the service files and were never exported from them. Let me do this as a follow up.
|
retest this please |
tylerjl
added a commit
to tylerjl/puppet-elasticsearch
that referenced
this pull request
Jul 12, 2017
default.path.data and default.path.log have been removed and cause errors on startup for versions 6.x and later.[1] Likewise, default.path.conf has been moved to path.conf.[2] [1]: elastic/elasticsearch#25408 [2]: elastic/elasticsearch#25392
cegeka-jenkins
pushed a commit
to cegeka/puppet-elasticsearch
that referenced
this pull request
Oct 23, 2017
default.path.data and default.path.log have been removed and cause errors on startup for versions 6.x and later.[1] Likewise, default.path.conf has been moved to path.conf.[2] [1]: elastic/elasticsearch#25408 [2]: elastic/elasticsearch#25392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the default path settings for data and logs. With this change, we now ship the packages with these settings set in the elasticsearch.yml configuration file rather than going through the default.path.data and default.path.logs dance that we went through in the past.
Relates #25357