Remove Sort enum from Painless Definition #26179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contained in the Sort enum was redudant and can be obtained from the existing data structures in other ways.
jdconrad
added a commit
that referenced
this pull request
Aug 17, 2017
This is step toward making Definition instanceable which is necessary for custom whitelists in different contexts.
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. All of the information contained in the Sort enum was redundant and can be obtained from the existing data structures members in slightly different ways. This not only reduces the amount of code, but also is a major step in making Definition instanceable. This change looks large, but it's impossible to remove sort without also modifying the majority of the AnalyzerCaster file, so in reality it's a lot of lines with minor changes. @rjernst Please don't reject this outright!