Add a limit to from + size in top_hits and inner hits. #26492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Search/Search
24 tasks
jimczi
approved these changes
Sep 4, 2017
| @@ -564,6 +574,14 @@ private void setMaxResultWindow(int maxResultWindow) { | |||
| this.maxResultWindow = maxResultWindow; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can you add the javdoc for this ?
martijnvg
force-pushed
the
max_result_window_inner_hits_top_hits
branch
from
e1e7eff
to
3c93ad1
Compare
martijnvg
force-pushed
the
max_result_window_inner_hits_top_hits
branch
from
1e23c7a
to
78e9c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11511