Add version parameter to index template. #27135
Conversation
|
Thanks guys! Can I piggy-back this same request (if you haven't already) for the accompanying IGetIndexTemplateResponse to GetIndexTemplate to include version? (if that is indeed the proper place for it) |
| @@ -33,6 +33,10 @@ | |||
| "flat_settings": { | |||
| "type": "boolean", | |||
| "description": "Return settings in flat format (default: false)" | |||
| }, | |||
| "version": { | |||
There was a problem hiding this comment.
Maybe I am missing something, but I don't think we support version as a URL parameter. We do support it in the body of the template, but not on URL. And now that I am thinking about it we don't support flat_settings here either. So, we should probably remove it.
There was a problem hiding this comment.
I think that we do not support timeout either. But we support cause which is not listed in the spec. Also I am confused by template and index_patterns which are not specified in the spec. I guess we are missing some test coverage here as well, otherwise tests for these params would fail.
imotov
added
:Index Templates
:Core/Infra/REST API
|
My mistake, we do not need version in the url, we can include in the body, Closing PR |
clintongormley
added
:Data Management/Indices APIs
Cross reference from: elastic/elasticsearch-net#2880