Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version to PutTemplateRequest #2971

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Add version to PutTemplateRequest #2971

merged 3 commits into from
Dec 21, 2017

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Dec 20, 2017

Closes #2880

codebrain
codebrain approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam
Copy link
Contributor Author

russcam commented Dec 20, 2017

Also add version to IGetIndexTemplateResponse. See elastic/elasticsearch#27135 (comment)

russcam
russcam commented Dec 21, 2017
View reviewed changes
Copy link
Contributor Author

@russcam russcam left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpectJson needs to be changed, otherwise LGTM

Apologies, ExpectJson only asserts input, not output. Ignore 😄

src/Tests/Indices/IndexSettings/IndexTemplates/GetIndexTemplate/GetIndexTemplateApiTests.cs Outdated
protected override GetIndexTemplateRequest Initializer => new GetIndexTemplateRequest(CallIsolatedValue);

protected override object ExpectJson => new object();
Copy link
Contributor Author

@russcam russcam Dec 21, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to ExpectResponse, this won't be {} but will be an object with index patterns, version, template mappings and settings. Ignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can set this to null

src/Nest/Indices/IndexSettings/IndexTemplates/PutIndexTemplate/PutIndexTemplateRequest.cs Outdated
@@ -31,7 +29,7 @@ public partial class PutIndexTemplateDescriptor
{
int? ITemplateMapping.Order { get; set; }

int? IPutIndexTemplateRequest.Version { get; set; }
int? ITemplateMapping.Version { get; set; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Tests/Indices/IndexSettings/IndexTemplates/GetIndexTemplate/GetIndexTemplateApiTests.cs
@@ -9,7 +11,7 @@
namespace Tests.Indices.IndexSettings.IndexTemplates.GetIndexTemplate
{
public class GetIndexTemplateApiTests
: ApiTestBase<WritableCluster, IGetIndexTemplateResponse, IGetIndexTemplateRequest, GetIndexTemplateDescriptor, GetIndexTemplateRequest>
: ApiIntegrationTestBase<WritableCluster, IGetIndexTemplateResponse, IGetIndexTemplateRequest, GetIndexTemplateDescriptor, GetIndexTemplateRequest>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codebrain codebrain merged commit 0ed63dc into master Dec 21, 2017
codebrain added a commit that referenced this pull request Dec 21, 2017
@codebrain
Add version to PutTemplateRequest (#2971)
b297e33
@Mpdreamz Mpdreamz deleted the feature/put-template-version branch January 30, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebrain codebrain codebrain approved these changes

@Mpdreamz Mpdreamz Awaiting requested review from Mpdreamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@russcam @codebrain