Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify IntelliJ IDEA Jar Hell fix #27635

Merged
merged 2 commits into from
Dec 5, 2017

Conversation

catalin-ursachi
Copy link
Contributor

@catalin-ursachi catalin-ursachi commented Dec 3, 2017

Clarified the instructions for fixing IntelliJ's idea_rt.jar Jar hell issue (as updated by #27614); specifically, that:

  • Setting Shorten command line to classpath file is only necessary if the launcher is disabled via a JVM option.
  • If the launcher is disabled via an idea.properties setting, a restart is required (even though IntelliJ doesn't prompt you for one).

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@dnhatn dnhatn added >docs General docs changes >non-issue labels Dec 3, 2017
@dnhatn dnhatn added the v7.0.0 label Dec 3, 2017
@rjernst
Copy link
Member

rjernst commented Dec 4, 2017

I think the instructions adding the setting to idea.properties should stay next to the clause about 2017.2, and the 2017.3 instructions should be it's own sentence(s) after that.

@catalin-ursachi
Copy link
Contributor Author

catalin-ursachi commented Dec 4, 2017

So:

In order to run tests directly from IDEA 2017.2 and above, it is required to disable the IDEA run launcher in order to avoid idea_rt.jar causing "jar hell". This can be achieved by adding the -Didea.no.launcher=true JVM option, or by adding idea.no.launcher=true to the idea.properties file which can be accessed under Help > Edit Custom Properties (this will require a restart of IDEA). For IDEA 2017.3 and above, in addition to the JVM option, you will need to go to Run->Edit Configurations... and change the value for the Shorten command line setting from user-local default: none to classpath file.

?

@rjernst
Copy link
Member

rjernst commented Dec 5, 2017

Yes, but I would separate the "or" portion about idea.properties into a separate sentence (it sounds like a run-on sentence right now). Perhaps begin with Alternatively, `idea.no.launcher=true` can be set in the `idea.properties` file...

@jasontedor jasontedor requested review from rjernst and removed request for jasontedor December 5, 2017 05:25
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catalin-ursachi, looks good now.

@rjernst rjernst merged commit e584c52 into elastic:master Dec 5, 2017
@rjernst rjernst added the v6.2.0 label Dec 5, 2017
rjernst pushed a commit that referenced this pull request Dec 5, 2017
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 6, 2017
* master:
  Add a new cluster setting to limit the total number of buckets returned by a request (elastic#27581)
  Allow index settings to be reset by wildcards (elastic#27671)
  Fix UpdateMappingIntegrationIT test failures
  Correct docs for binary fields and their default for doc values (elastic#27680)
  Clarify IntelliJ IDEA Jar Hell fix (elastic#27635)
  Add validation of keystore setting names (elastic#27626)
  Prevent constructing index template without patterns (elastic#27662)
  [DOCS] Fixed typos and broken attribute.
  Add support for filtering mappings fields (elastic#27603)
  [DOCS] Added link to upgrade guide and bumped the upgrade topic up to the top level (elastic#27621)
  [Geo] Add Well Known Text (WKT) Parsing Support to ShapeBuilders
  Fix up tests now that GeoDistance.*.calculate works (elastic#27541)
  [Docs] Fix parameter name (elastic#27656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants