-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify IntelliJ IDEA Jar Hell fix #27635
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
I think the instructions adding the setting to idea.properties should stay next to the clause about 2017.2, and the 2017.3 instructions should be it's own sentence(s) after that. |
So:
? |
Yes, but I would separate the "or" portion about idea.properties into a separate sentence (it sounds like a run-on sentence right now). Perhaps begin with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @catalin-ursachi, looks good now.
* master: Add a new cluster setting to limit the total number of buckets returned by a request (elastic#27581) Allow index settings to be reset by wildcards (elastic#27671) Fix UpdateMappingIntegrationIT test failures Correct docs for binary fields and their default for doc values (elastic#27680) Clarify IntelliJ IDEA Jar Hell fix (elastic#27635) Add validation of keystore setting names (elastic#27626) Prevent constructing index template without patterns (elastic#27662) [DOCS] Fixed typos and broken attribute. Add support for filtering mappings fields (elastic#27603) [DOCS] Added link to upgrade guide and bumped the upgrade topic up to the top level (elastic#27621) [Geo] Add Well Known Text (WKT) Parsing Support to ShapeBuilders Fix up tests now that GeoDistance.*.calculate works (elastic#27541) [Docs] Fix parameter name (elastic#27656)
Clarified the instructions for fixing IntelliJ's
idea_rt.jar
Jar hell issue (as updated by #27614); specifically, that:Shorten command line
toclasspath file
is only necessary if the launcher is disabled via a JVM option.idea.properties
setting, a restart is required (even though IntelliJ doesn't prompt you for one).