-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outgoing NodeID #28779
Fix outgoing NodeID #28779
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -299,6 +299,12 @@ public void testOutgoingThrottlesAllocation() { | |
new MoveAllocationCommand("test", 0, "node2", "node4")), true, false); | ||
assertEquals(commandsResult.explanations().explanations().size(), 1); | ||
assertEquals(commandsResult.explanations().explanations().get(0).decisions().type(), Decision.Type.THROTTLE); | ||
for(Decision decision : commandsResult.explanations().explanations().get(0).decisions().getDecisions()){ | ||
if(decision.label().equals(ThrottlingAllocationDecider.NAME)){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: please add spaces after the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
assertEquals("reached the limit of outgoing shard recoveries [1] on the node [node1] which holds the primary, " + | ||
"cluster setting [cluster.routing.allocation.node_concurrent_outgoing_recoveries=1] (can also be set via [cluster.routing.allocation.node_concurrent_recoveries])",decision.getExplanation()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line is longer than 120 characters so CI will reject it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: please add a space before the |
||
} | ||
} | ||
// even though it is throttled, move command still forces allocation | ||
|
||
clusterState = commandsResult.getClusterState(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: please add spaces after the
for
and before the{
.