Call addBytesSent with correct number of bytes #29194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to elastic#27258. Currently we call the transport service adaptor with the number of readable bytes once a message has been sent. However, the number of readable bytes should be zero as the bytebuf has been consumed. This commit fixes that issue by recording the number of bytes.
Tim-Brooks
added
>bug
review
:Distributed/Network
|
Pinging @elastic/es-core-infra |
|
Not my catch, community issue (#27258). I encountered it when going through the backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #27258. Currently we call the transport service
adaptor with the number of readable bytes once a message has been sent.
However, the number of readable bytes should be zero as the bytebuf has
been consumed. This commit fixes that issue by recording the number of
bytes.