HLRC: Fixing bug when getting a missing pipeline #34286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
jtibshirani
approved these changes
Oct 6, 2018
| @@ -83,7 +84,7 @@ public void putPipelineAsync(PutPipelineRequest request, RequestOptions options, | |||
| */ | |||
| public GetPipelineResponse getPipeline(GetPipelineRequest request, RequestOptions options) throws IOException { | |||
| return restHighLevelClient.performRequestAndParseEntity( request, IngestRequestConverters::getPipeline, options, | |||
| GetPipelineResponse::fromXContent, emptySet()); | |||
| GetPipelineResponse::fromXContent, Collections.singleton(404)); | |||
There was a problem hiding this comment.
Big nitpick, mostly for future reference: would be nice we statically imported this, for consistency with emptySet.
benwtrent
added a commit
that referenced
this pull request
Oct 6, 2018
benwtrent
added a commit
that referenced
this pull request
Oct 6, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
getPipelineAPI call to ignore404errors so that the method callGetPipelineResponse::isFoundis useful again :)closes #34119