Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Swift plugin on 5.X banches #34633

Merged
merged 1 commit into from Oct 26, 2018
Merged

Conversation

johnsudaar
Copy link

Swift plugin is not (and will not) be available on ES 5.X versions (see: BigDataBoutique/elasticsearch-repository-swift#3 (comment))

  • Have you signed the contributor license agreement? YES
  • Have you followed the contributor guidelines? YES
  • If submitting code, have you built your formula locally prior to submission with gradle check? N/A
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. N/A
  • If submitting code, have you checked that your submission is for an OS that we support? N/A
  • If you are submitting this code for a class then read our policy for that. N/A

@johnsudaar johnsudaar changed the base branch from master to 5.5 October 19, 2018 11:46
@johnsudaar johnsudaar changed the base branch from 5.5 to master October 19, 2018 11:46
Swift plugin is not (and will not) be available on ES 5.X versions (see: BigDataBoutique/elasticsearch-repository-swift#3 (comment))
@johnsudaar johnsudaar changed the base branch from master to 5.5 October 19, 2018 11:57
@colings86 colings86 added >docs General docs changes :Docs labels Oct 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnsudaar,

thanks for the update, looking at the discussion it makes sense to me to remove the plugin from the 5.x docs. Do you think it also makes sense to update the Link to point to https://github.com/BigDataBoutique/elasticsearch-repository-swift for later versions, starting with 6.0? Looking at the repo I'm not sure if the plugin supports 6.x versions yet.
I will go ahead and merge this change to the 5.x branches, let me know if you think this warrants a follow-up agains the current master and 6.x branches too.

@cbuescher cbuescher merged commit b51ac8a into elastic:5.5 Oct 26, 2018
cbuescher pushed a commit that referenced this pull request Oct 26, 2018
Swift plugin is not (and will not) be available on ES 5.X versions (see: BigDataBoutique/elasticsearch-repository-swift#3 (comment))
YallZhang added a commit to YallZhang/elasticsearch that referenced this pull request Oct 28, 2018
[Docs] Remove Swift plugin on 5.X banches (elastic#34633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes v5.5.4 v5.6.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants