HLRC XPack Protocol clean up: Migration; Graph; Watcher #34639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 15, 2018 15:37
Drop protocol module Relates elastic#34451
|
Pinging @elastic/es-core-infra |
7 tasks
nik9000
reviewed
Oct 19, 2018
|
|
||
| public class IndexUpgradeInfoResponseTests extends AbstractStreamableXContentTestCase<IndexUpgradeInfoResponse> { | ||
| @Override | ||
| protected IndexUpgradeInfoResponse doParseInstance(XContentParser parser) { |
There was a problem hiding this comment.
Can we keep these tests somehow so we're fairly confident of the parsing? Not, like, the tests how they look now, but some kind of parsing tests? Like we've done for the rollup response stuff?
vladimirdolzhenko
changed the base branch from
hlrc_xprotocol_cleanup_1
to
master
added 5 commits
October 19, 2018 21:33
nik9000
approved these changes
Oct 24, 2018
| import org.elasticsearch.test.ESTestCase; | ||
|
|
||
| public class IndexUpgradeInfoResponseTests extends ESTestCase { | ||
| // TODO: add to cross XPack-HLRC serialization test |
There was a problem hiding this comment.
👍 I see you already have that in flight in another PR so this is fine by me!
hub-cap
approved these changes
Oct 25, 2018
| @@ -51,7 +51,6 @@ dependencies { | |||
| compile "org.elasticsearch.plugin:aggs-matrix-stats-client:${version}" | |||
| compile "org.elasticsearch.plugin:rank-eval-client:${version}" | |||
| compile "org.elasticsearch.plugin:lang-mustache-client:${version}" | |||
| bundle project(':x-pack:protocol') | |||
| ActionRequestValidationException validationException = null; | ||
| if (id == null){ | ||
| validationException = ValidateActions.addValidationError("watch id is missing", validationException); | ||
| public Optional<ValidationException> validate() { |
There was a problem hiding this comment.
lets put this in the constructor instead if possible.
| @@ -136,20 +109,20 @@ public void setVersion(long version) { | |||
| } | |||
|
|
|||
| @Override | |||
| public ActionRequestValidationException validate() { | |||
| ActionRequestValidationException validationException = null; | |||
| public Optional<ValidationException> validate() { | |||
There was a problem hiding this comment.
can we move this to the constructor a-la https://github.com/elastic/elasticsearch/blob/master/client/rest-high-level/src/main/java/org/elasticsearch/client/watcher/DeactivateWatchRequest.java#L29-L37
added 2 commits
October 26, 2018 08:21
|
❤️ |
vladimirdolzhenko
added a commit
to vladimirdolzhenko/elasticsearch
that referenced
this pull request
Oct 29, 2018
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client Drop protocol module Relates elastic#34451, backport of elastic#34639 (cherry picked from commit 69fe9a1)
vladimirdolzhenko
added a commit
that referenced
this pull request
Oct 29, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client Drop protocol module Relates #34451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client
Drop protocol module
Relates #34451