Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLRC XPack protocol clean up #34451

Closed
6 of 7 tasks
vladimirdolzhenko opened this issue Oct 15, 2018 · 3 comments
Closed
6 of 7 tasks

HLRC XPack protocol clean up #34451

vladimirdolzhenko opened this issue Oct 15, 2018 · 3 comments
Assignees
@vladimirdolzhenko @hub-cap
Labels
>breaking-java Meta >refactoring

Comments

@vladimirdolzhenko
Copy link
Contributor

vladimirdolzhenko commented Oct 15, 2018 •
edited

Relates to XPack HLRC #29827

There are some requests/responses in xpack protocol, while most requests/responses are in client/rest-high-level (proper place)

Move ( + clean up ) HLRC located at xpack protocol to client/rest-high-level

Note: In most cases everything is there, except maybe some tests like RequestConvertersTests and unit tests.

Clean up assumes don't extend AcknowledgedRequest, readFrom(StreamInput in) / writeTo(StreamOutput out)
@vladimirdolzhenko vladimirdolzhenko self-assigned this Oct 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@hub-cap
Copy link
Contributor

hub-cap commented Oct 15, 2018

I think it would be good to also clean up the existing actions we moved from, for instance, we tended to add some XContent methods to the existing request/response that are not needed, so lets try to also revert the history of the moved code in the x-pack directory to something that was before we started the migration.

vladimirdolzhenko pushed a commit to vladimirdolzhenko/elasticsearch that referenced this issue Oct 15, 2018
HLRC XPack Protocol clean up: Licence, Misc
7d3f9d6 
Relates elastic#34451
@vladimirdolzhenko vladimirdolzhenko mentioned this issue Oct 15, 2018
Merged
@hub-cap hub-cap self-assigned this Oct 15, 2018
vladimirdolzhenko pushed a commit to vladimirdolzhenko/elasticsearch that referenced this issue Oct 17, 2018
XPack/OSS request/response compatibility tests
10c9bb8 
Relates to elastic#34451
@vladimirdolzhenko vladimirdolzhenko mentioned this issue Oct 17, 2018
Merged
vladimirdolzhenko pushed a commit to vladimirdolzhenko/elasticsearch that referenced this issue Oct 19, 2018
HLRC XPack Protocol clean up: Migration; Graph; Watcher
ad85b75 
Drop protocol module

Relates elastic#34451
@vladimirdolzhenko vladimirdolzhenko mentioned this issue Oct 19, 2018
Merged
vladimirdolzhenko added a commit that referenced this issue Oct 19, 2018
@vladimirdolzhenko
HLRC XPack Protocol clean up: Licence, Misc (#34469)
423d085 
Relates #34451
vladimirdolzhenko added a commit that referenced this issue Oct 19, 2018
@vladimirdolzhenko
HLRC XPack Protocol clean up: Licence, Misc (#34469)
21a25d6 
Relates #34451

(cherry picked from commit 423d085)
vladimirdolzhenko added a commit that referenced this issue Oct 29, 2018
@vladimirdolzhenko
HLRC XPack Protocol clean up: Migration; Graph; Watcher (#34639)
69fe9a1 
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client

Drop protocol module

Relates #34451
vladimirdolzhenko added a commit to vladimirdolzhenko/elasticsearch that referenced this issue Oct 29, 2018
@vladimirdolzhenko
HLRC XPack Protocol clean up: Migration; Graph; Watcher (elastic#34639)
14f0f6d 
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client

Drop protocol module

Relates elastic#34451, backport of elastic#34639

(cherry picked from commit 69fe9a1)
@vladimirdolzhenko vladimirdolzhenko mentioned this issue Oct 29, 2018
Merged
vladimirdolzhenko added a commit that referenced this issue Oct 29, 2018
@vladimirdolzhenko
HLRC XPack Protocol clean up: Migration; Graph; Watcher (#34964)
3b5e2f1 
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client

Drop protocol module

Relates #34451, backport of #34639

(cherry picked from commit 69fe9a1)
kcm pushed a commit that referenced this issue Oct 30, 2018
@vladimirdolzhenko @kcm
HLRC XPack Protocol clean up: Licence, Misc (#34469)
47ed8f6 
Relates #34451
kcm pushed a commit that referenced this issue Oct 30, 2018
@vladimirdolzhenko @kcm
HLRC XPack Protocol clean up: Migration; Graph; Watcher (#34639)
d0a7a22 
Move parts related to XPack for packages Migration; Graph; Watcher from protocol to client

Drop protocol module

Relates #34451
vladimirdolzhenko added a commit that referenced this issue Oct 31, 2018
@vladimirdolzhenko
XPack/HLRC request/response compatibility tests (#34547)
28bb1a3 
Relates #34451 , #29827
vladimirdolzhenko added a commit to vladimirdolzhenko/elasticsearch that referenced this issue Oct 31, 2018
@vladimirdolzhenko
XPack/HLRC request/response compatibility tests
d17f150 
Relates elastic#34451 , backports elastic#34547

(cherry picked from commit 28bb1a3)
@vladimirdolzhenko vladimirdolzhenko mentioned this issue Oct 31, 2018
Merged
vladimirdolzhenko added a commit that referenced this issue Oct 31, 2018
@vladimirdolzhenko
XPack/HLRC request/response compatibility tests (#35129)
212e78a 
Relates #34451 , backports #34547

(cherry picked from commit 28bb1a3)
@hub-cap
Copy link
Contributor

hub-cap commented Aug 13, 2019

This can be closed as we will likely not modify them, and instead wait to do the work of generation of the code.

@hub-cap hub-cap closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirdolzhenko vladimirdolzhenko

@hub-cap hub-cap

Labels
>breaking-java Meta >refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vladimirdolzhenko @hub-cap @elasticmachine