Auto configure all test tasks #34666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we apply the common test config automatically to all newly created tasks instead of opting in specifically. For plugin authors using the plugin externally this means that the configuration will be applied to their RandomizedTestingTasks as well. The purpose of the task is to simplify setup and make it easier to change projects that use the `test` task but actually run integration tests to use a task called `integTest` for clarity, but also because we may want to configure and run them differently. E.x. using different levels of concurrency.
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Oct 23, 2018
| /** Returns a closure of common configuration shared by unit and integration tests. */ | ||
| static Closure commonTestConfig(Project project) { | ||
| return { | ||
| static void applyCommonTestConfigPresentAndFuture(Project project) { |
There was a problem hiding this comment.
We have other methods here which apply to all existing and future items of a type. I don't think we need such a verbose name for these cases. configureTests should be sufficient?
There was a problem hiding this comment.
In retrospect that does seem excessive.
I think there is some value in coming up with something other than apply and configure to distinguish between what configures the current state vs attaching configuration to the domain object containers that affect future state.
For me this is one of the top confusions and sources of bugs, but we can do this in a follow up, I simplified the name for now.
|
@elasticmachine test this please |
alpar-t
added a commit
to alpar-t/elasticsearch
that referenced
this pull request
Oct 24, 2018
With this change, we apply the common test config automatically to all newly created tasks instead of opting in specifically. For plugin authors using the plugin externally this means that the configuration will be applied to their RandomizedTestingTasks as well. The purpose of the task is to simplify setup and make it easier to change projects that use the `test` task but actually run integration tests to use a task called `integTest` for clarity, but also because we may want to configure and run them differently. E.x. using different levels of concurrency.
alpar-t
added a commit
that referenced
this pull request
Oct 25, 2018
* Auto configure all test tasks (#34666) With this change, we apply the common test config automatically to all newly created tasks instead of opting in specifically. For plugin authors using the plugin externally this means that the configuration will be applied to their RandomizedTestingTasks as well. The purpose of the task is to simplify setup and make it easier to change projects that use the `test` task but actually run integration tests to use a task called `integTest` for clarity, but also because we may want to configure and run them differently. E.x. using different levels of concurrency. * Convert tests using old method
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
With this change, we apply the common test config automatically to all newly created tasks instead of opting in specifically. For plugin authors using the plugin externally this means that the configuration will be applied to their RandomizedTestingTasks as well. The purpose of the task is to simplify setup and make it easier to change projects that use the `test` task but actually run integration tests to use a task called `integTest` for clarity, but also because we may want to configure and run them differently. E.x. using different levels of concurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we apply the common test config automatically to all
newly created test tasks instead of opting in specifically.
For plugin authors using the plugin externally this means that the
configuration will be applied to their RandomizedTestingTasks as well.
The purpose of the task is to simplify setup and make it easier to
change projects that use the
testtask but actually run integrationtests to use a task called
integTestfor clarity, but also becausewe may want to configure and run them differently.
E.x. using different levels of concurrency.