Scripting: Add back params._source access in scripted metric aggs #34777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to special variables _source and _fields were accidentally removed in recent refactorings. This commit adds them back, along with a test. closes elastic#33884
rjernst
added
>bug
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
jdconrad
approved these changes
Oct 23, 2018
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 24, 2018
…astic#34777) Access to special variables _source and _fields were accidentally removed in recent refactorings. This commit adds them back, along with a test. closes elastic#33884
rjernst
added a commit
that referenced
this pull request
Oct 30, 2018
rjernst
added a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to special variables _source and _fields were accidentally
removed in recent refactorings. This commit adds them back, along with a
test.
closes #33884