Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting: Add back params._source access in scripted metric aggs (#34777) #34832

Merged
merged 5 commits into from Oct 30, 2018

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Oct 24, 2018

Access to special variables _source and _fields were accidentally
removed in recent refactorings. This commit adds them back, along with a
test.

closes #33884

…astic#34777)

Access to special variables _source and _fields were accidentally
removed in recent refactorings. This commit adds them back, along with a
test.

closes elastic#33884
@rjernst
Copy link
Member Author

rjernst commented Oct 24, 2018

This is a backport of #34777, opened for CI testing.

@colings86 colings86 added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Oct 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86 colings86 removed the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Oct 25, 2018
@colings86
Copy link
Contributor

Sorry for the notification noise, I didn't notice this was a backport until after I added the label

@rjernst rjernst merged commit 6cf5b42 into elastic:6.x Oct 30, 2018
@rjernst rjernst deleted the backport_34777 branch October 30, 2018 20:24
rjernst added a commit that referenced this pull request Oct 30, 2018
…4777) (#34832)

Access to special variables _source and _fields were accidentally
removed in recent refactorings. This commit adds them back, along with a
test.

closes #33884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants