[HLRC] Add GetRollupIndexCaps API #35102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors the caps response tests a bit to share the same abstract class to reduce duplication of test code
|
Pinging @elastic/es-core-infra |
98 tasks
hub-cap
suggested changes
Nov 2, 2018
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| public class GetRollupIndexCapsResponse implements ToXContentObject { |
There was a problem hiding this comment.
Generally speaking these responses shouldnt be ToXContent classes. I assume this is for a test case below. We have some newer HLRC's that have a diff test, see TermVectorsResponseTests. It looks like you picked the short straw that came after we modified the tests, sorry :)
There was a problem hiding this comment.
Ah, yeah, think I just c/p from some boilerplate before the testing changed. Will make the changes, sorry about that!
There was a problem hiding this comment.
no, we are just changing things quickly on the client :)
hub-cap
approved these changes
Nov 12, 2018
|
Thanks @hub-cap! <3 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 13, 2018
* master: (22 commits) Introduce CCR getting started guide (elastic#35434) Correct typo in BuildPlugin exception message (elastic#35458) Correct implemented interface of ParsedReverseNested (elastic#35455) [ML] Fix find_file_structure NPE with should_trim_fields (elastic#35465) Handle OS pretty name on old OS without OS release (elastic#35453) Register remote cluster compress setting (elastic#35464) [DOCS] Clarify results_index_name description (elastic#35463) [TEST] add missing doc tests for HLRC GetRollupIndexCaps API [HLRC] Add GetRollupIndexCaps API (elastic#35102) Geo: enables coerce support in WKT polygon parser (elastic#35414) [ILM] fix retry so it picks up latest policy and executes async action (elastic#35406) Address handling of OS pretty name on some OS (elastic#35451) HLRC support for getTask (elastic#35166) upgrade to lucene-8.0.0-snapshot-6d9c714052 (elastic#35428) Add docs for CCR stats API (elastic#35439) Fix the names of CCR stats endpoints in usage API (elastic#35438) Switch to default to no build qualifier (elastic#35415) Clarify S3 repository storage class parameter (elastic#35400) SQL: Fix query translation for scripted queries (elastic#35408) [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI. ...
polyfractal
added a commit
that referenced
this pull request
Nov 13, 2018
Also refactors the caps response tests a bit to share the same abstract class to reduce duplication of test code
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 21, 2018
Also refactors the caps response tests a bit to share the same abstract class to reduce duplication of test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly identical to the GetRollupCaps API since the response is basically the same format, just different content. The request object is slightly different too since it accepts a list of indices/index patterns and IndicesOptions
Also refactors the caps response tests a bit to share the same abstract class to reduce duplication of test code
Related to #29827