SQL: Fix query translation for scripted queries #35408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsNull, IsNotNull and Not where generating wrong queries as the check to generate ScriptQuery was missing. Fixes: elastic#35232
|
Pinging @elastic/es-search-aggs |
matriv
commented
Nov 9, 2018
| @@ -21,7 +20,7 @@ | |||
| /** | |||
| * Negation function (@{code -x}). | |||
| */ | |||
| public class Neg extends UnaryScalarFunction implements ScriptWeaver { | |||
There was a problem hiding this comment.
ScalarFunction already implements ScriptWeaver
matriv
commented
Nov 9, 2018
| @@ -845,6 +818,14 @@ public QueryTranslation translate(Expression exp, boolean onAggs) { | |||
|
|
|||
| protected abstract QueryTranslation asQuery(E e, boolean onAggs); | |||
|
|
|||
|
|
|||
| protected static Query generateQuery(ScalarFunction sf, Expression field, Supplier<Query> query) { | |||
There was a problem hiding this comment.
maybe better suggestion for a name here?
There was a problem hiding this comment.
wrapQuery/handleQuery/handleScript?
costin
approved these changes
Nov 11, 2018
| @@ -845,6 +818,14 @@ public QueryTranslation translate(Expression exp, boolean onAggs) { | |||
|
|
|||
| protected abstract QueryTranslation asQuery(E e, boolean onAggs); | |||
|
|
|||
|
|
|||
| protected static Query generateQuery(ScalarFunction sf, Expression field, Supplier<Query> query) { | |||
There was a problem hiding this comment.
wrapQuery/handleQuery/handleScript?
matriv
pushed a commit
that referenced
this pull request
Nov 12, 2018
IsNull, IsNotNull and Not where generating wrong queries as the check to generate ScriptQuery was missing. Fixes: #35232
|
Backported to |
matriv
pushed a commit
that referenced
this pull request
Nov 12, 2018
IsNull, IsNotNull and Not where generating wrong queries as the check to generate ScriptQuery was missing. Fixes: #35232
|
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 12, 2018
* master: Add docs for CCR stats API (elastic#35439) Fix the names of CCR stats endpoints in usage API (elastic#35438) Switch to default to no build qualifier (elastic#35415) Clarify S3 repository storage class parameter (elastic#35400) SQL: Fix query translation for scripted queries (elastic#35408) [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI. Upgrade to Joda 2.10.1 (elastic#35410) HLRest: model role and privileges (elastic#35128)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 12, 2018
* master: Add docs for CCR stats API (elastic#35439) Fix the names of CCR stats endpoints in usage API (elastic#35438) Switch to default to no build qualifier (elastic#35415) Clarify S3 repository storage class parameter (elastic#35400) SQL: Fix query translation for scripted queries (elastic#35408) [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI. Upgrade to Joda 2.10.1 (elastic#35410) HLRest: model role and privileges (elastic#35128)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 12, 2018
* master: Address handling of OS pretty name on some OS (elastic#35451) HLRC support for getTask (elastic#35166) upgrade to lucene-8.0.0-snapshot-6d9c714052 (elastic#35428) Add docs for CCR stats API (elastic#35439) Fix the names of CCR stats endpoints in usage API (elastic#35438) Switch to default to no build qualifier (elastic#35415) Clarify S3 repository storage class parameter (elastic#35400) SQL: Fix query translation for scripted queries (elastic#35408) [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI. Upgrade to Joda 2.10.1 (elastic#35410) HLRest: model role and privileges (elastic#35128)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 13, 2018
* master: (22 commits) Introduce CCR getting started guide (elastic#35434) Correct typo in BuildPlugin exception message (elastic#35458) Correct implemented interface of ParsedReverseNested (elastic#35455) [ML] Fix find_file_structure NPE with should_trim_fields (elastic#35465) Handle OS pretty name on old OS without OS release (elastic#35453) Register remote cluster compress setting (elastic#35464) [DOCS] Clarify results_index_name description (elastic#35463) [TEST] add missing doc tests for HLRC GetRollupIndexCaps API [HLRC] Add GetRollupIndexCaps API (elastic#35102) Geo: enables coerce support in WKT polygon parser (elastic#35414) [ILM] fix retry so it picks up latest policy and executes async action (elastic#35406) Address handling of OS pretty name on some OS (elastic#35451) HLRC support for getTask (elastic#35166) upgrade to lucene-8.0.0-snapshot-6d9c714052 (elastic#35428) Add docs for CCR stats API (elastic#35439) Fix the names of CCR stats endpoints in usage API (elastic#35438) Switch to default to no build qualifier (elastic#35415) Clarify S3 repository storage class parameter (elastic#35400) SQL: Fix query translation for scripted queries (elastic#35408) [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI. ...
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 21, 2018
IsNull, IsNotNull and Not where generating wrong queries as the check to generate ScriptQuery was missing. Fixes: elastic#35232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsNull, IsNotNull and Not where generating wrong queries
as the check to generate ScriptQuery was missing.
Fixes: #35232