Rest HL client: Add watcher stats API #35185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
hub-cap
suggested changes
Nov 5, 2018
| String endpoint = builder.build(); | ||
| Request request = new Request(HttpGet.METHOD_NAME, endpoint); | ||
| RequestConverters.Params parameters = new RequestConverters.Params(request); | ||
| StringBuilder metric = new StringBuilder(); |
There was a problem hiding this comment.
two spaces between StringBuilder and metric
| new RequestConverters.EndpointBuilder() | ||
| .addPathPartAsIs("_xpack") | ||
| .addPathPartAsIs("watcher") | ||
| .addPathPartAsIs("stats"); |
There was a problem hiding this comment.
addPathPartAsIs now takes a variadic
| * under the License. | ||
| */ | ||
|
|
||
|
|
| */ | ||
| public class WatcherStatsRequest implements Validatable { | ||
|
|
||
| private boolean includeCurrentWatches; |
There was a problem hiding this comment.
if there is no reason to make these mutable, lets make these final and have 2 constructors, a default one where we set them both to (im going to guess false, but thats up to you), and a 2 arg constructor where we ensure both are set.
| return watcherMetaData; | ||
| } | ||
|
|
||
|
|
|
|
||
| @Override | ||
| public int hashCode() { | ||
|
|
...est-high-level/src/test/java/org/elasticsearch/client/watcher/WatcherStatsResponseTests.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #29827