Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused class MemoryCircuitBreaker #35367

Conversation

danielmitterdorfer
Copy link
Member

The class MemoryCircuitBreaker is unused so we remove all its traces
from the code base.

The class `MemoryCircuitBreaker` is unused so we remove all its traces
from the code base.
@danielmitterdorfer danielmitterdorfer added >non-issue :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload v7.0.0 v6.5.1 labels Nov 8, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danielmitterdorfer
Copy link
Member Author

Thanks for the quick review. :)

@danielmitterdorfer
Copy link
Member Author

@elasticmachine retest this please

@danielmitterdorfer danielmitterdorfer merged commit 6980fed into elastic:master Nov 8, 2018
@danielmitterdorfer danielmitterdorfer deleted the remove-mem-circuit-breaker branch November 8, 2018 14:33
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 9, 2018
danielmitterdorfer added a commit that referenced this pull request Nov 26, 2018
The class `MemoryCircuitBreaker` is unused so we remove all its traces
from the code base.

Relates #35367
@danielmitterdorfer
Copy link
Member Author

Backported to 6.x in a064fd0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload >non-issue v6.5.2 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants