Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Joda 2.10.1 #35410

Merged
merged 3 commits into from Nov 12, 2018
Merged

Upgrade to Joda 2.10.1 #35410

merged 3 commits into from Nov 12, 2018

Conversation

cbuescher
Copy link
Member

This version contains a bugfix that allows us to reenable one of our muted tests
in DateTimeUnitTests.

Closes #33749

This version contains a bugfix that allows us to reenable one of our muted tests
in DateTimeUnitTests.

Closes elastic#33749
Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The joda-time version could be added to buildSrc/version.properties and refferenced trough project.versions to avoid the repetition.

@cbuescher
Copy link
Member Author

The joda-time version could be added to buildSrc/version.properties and refferenced trough project.versions to avoid the repetition.

Good point, will do that before I merge.

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbuescher cbuescher merged commit 09cac32 into elastic:master Nov 12, 2018
cbuescher pushed a commit that referenced this pull request Nov 12, 2018
This version contains several bugfixes.

Closes #33749
cbuescher pushed a commit that referenced this pull request Nov 12, 2018
This version contains several bugfixes.

Closes #33749
shuaibiyy added a commit to shuaibiyy/elasticsearch that referenced this pull request Nov 12, 2018
shuaibiyy added a commit to shuaibiyy/elasticsearch that referenced this pull request Nov 12, 2018
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 12, 2018
* master:
  Add docs for CCR stats API (elastic#35439)
  Fix the names of CCR stats endpoints in usage API (elastic#35438)
  Switch to default to no build qualifier (elastic#35415)
  Clarify S3 repository storage class parameter (elastic#35400)
  SQL: Fix query translation for scripted queries (elastic#35408)
  [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI.
  Upgrade to Joda 2.10.1 (elastic#35410)
  HLRest: model role and privileges (elastic#35128)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 12, 2018
* master:
  Add docs for CCR stats API (elastic#35439)
  Fix the names of CCR stats endpoints in usage API (elastic#35438)
  Switch to default to no build qualifier (elastic#35415)
  Clarify S3 repository storage class parameter (elastic#35400)
  SQL: Fix query translation for scripted queries (elastic#35408)
  [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI.
  Upgrade to Joda 2.10.1 (elastic#35410)
  HLRest: model role and privileges (elastic#35128)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 12, 2018
* master:
  Address handling of OS pretty name on some OS (elastic#35451)
  HLRC support for getTask (elastic#35166)
  upgrade to lucene-8.0.0-snapshot-6d9c714052 (elastic#35428)
  Add docs for CCR stats API (elastic#35439)
  Fix the names of CCR stats endpoints in usage API (elastic#35438)
  Switch to default to no build qualifier (elastic#35415)
  Clarify S3 repository storage class parameter (elastic#35400)
  SQL: Fix query translation for scripted queries (elastic#35408)
  [TEST] Instead of ignoring the ccr downgrade to basic license qa test avoid the assertions that check the log files, because that does not work on Windows. The rest of the test is still useful and should work on Windows CI.
  Upgrade to Joda 2.10.1 (elastic#35410)
  HLRest: model role and privileges (elastic#35128)
shuaibiyy added a commit to shuaibiyy/elasticsearch that referenced this pull request Nov 13, 2018
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this pull request Nov 21, 2018
This version contains a bugfix that allows us to reenable one of our muted tests
in DateTimeUnitTests.

Closes elastic#33749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] DateTimeUnitTests.testConversion fails reproducibly for certain seeds
3 participants