-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLRC: Add "_has_privileges" API to Security Client #35479
Conversation
This adds the "hasPrivileges()" method to SecurityClient, including request, response & async variant of the method. Also includes API documentation.
Pinging @elastic/es-core-infra |
CC: @elastic/es-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
I would've used AbstractHlrcStreamableXContentTestCase
for HasPrivilegesResponseTests
. It's easier to write and more valuable as it tests the serialization against the server entity. And maybe added AbstractHlrcStreamableXContentTestCase
. We also should reserve some time, when all APIs are done, to write tests in SecurityIT
.
...t/rest-high-level/src/main/java/org/elasticsearch/client/security/HasPrivilegesResponse.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scrap that, I worked it out. |
@albertzaharovits I'm going to raise the |
This adds the "hasPrivileges()" method to SecurityClient, including request, response & async variant of the method. Also includes API documentation.
This adds the "hasPrivileges()" method to SecurityClient, including
request, response & async variant of the method.
Also includes API documentation.
Relates: #29827