SNAPSHOT: Improve Resilience SnapshotShardService #36113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolve the index in the snapshotting thread * Added test for routing table - snapshot state mismatch
original-brownbear
added
>bug
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Dec 3, 2018
| executor.execute(new AbstractRunnable() { | ||
|
|
||
| final SetOnce<Exception> failure = new SetOnce<>(); | ||
|
|
||
| @Override | ||
| public void doRun() { | ||
| final IndexShard indexShard = indicesService.indexServiceSafe(shardId.getIndex()).getShardOrNull(shardId.id()); | ||
| final IndexId indexId = indicesMap.get(shardId.getIndexName()); |
There was a problem hiding this comment.
this can and should still be resolved outside the executor.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 3, 2018
* Resolve the index in the snapshotting thread * Added test for routing table - snapshot state mismatch
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Dec 3, 2018
* Resolve the index in the snapshotting thread * Added test for routing table - snapshot state mismatch
original-brownbear
added a commit
that referenced
this pull request
Dec 3, 2018
original-brownbear
added a commit
that referenced
this pull request
Dec 3, 2018
This was referenced Jan 15, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Apr 24, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
5 tasks
kovrus
added a commit
to crate/crate
that referenced
this pull request
Apr 25, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
kovrus
added a commit
to crate/crate
that referenced
this pull request
Apr 25, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
kovrus
added a commit
to crate/crate
that referenced
this pull request
Apr 25, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
kovrus
added a commit
to crate/crate
that referenced
this pull request
Apr 25, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
kovrus
added a commit
to crate/crate
that referenced
this pull request
Apr 26, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Apr 26, 2019
- Fix two races condition that lead to stuck snapshots (elastic/elasticsearch#37686) - Improve resilience SnapshotShardService (elastic/elasticsearch#36113) - Fix concurrent snapshot ending and stabilize snapshot finalization (elastic/elasticsearch#38368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexIdin the snapshot thread improves resilience in general because it covers any situations where the interaction withindicesServiceruns into an exception but that exception is never reported to the master