[ML-DataFrame] cancel indexer on job deletion and remove task, allow only stopped jo… #36204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
added 2 commits
December 4, 2018 14:03
hendrikmuhs
force-pushed
the
feature/fib-deletion-fixes
branch
from
cc5a7d0
to
2e5bf1a
Compare
benwtrent
approved these changes
Dec 4, 2018
|
|
||
| public Response() { | ||
| super(Collections.emptyList(), Collections.emptyList()); | ||
| this.acknowledged = false; |
There was a problem hiding this comment.
#nit
All these constructors could just call the appropriate overloaded constructor. Example
Suggested change
| this.acknowledged = false; | |
| this(false, Collections.emptyList(), Collections.emptyList()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Branch PR
cancel indexer on job deletion and remove task, allow only stopped jobs to be deleted
Notes: