[Close Index API] Add TransportShardCloseAction for pre-closing verifications #36249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
v7.0.0
:Distributed/Distributed
|
Pinging @elastic/es-distributed |
tlrx
commented
Dec 5, 2018
| import org.elasticsearch.threadpool.ThreadPool; | ||
| import org.elasticsearch.transport.TransportService; | ||
|
|
||
| public class TransportShardCloseAction extends TransportReplicationAction<ShardCloseRequest, ShardCloseRequest, ReplicationResponse> { |
There was a problem hiding this comment.
I hesitated on the name of the action and request as it does not really close the shard. Suggestions welcome.
There was a problem hiding this comment.
TransportVerifyShardBeforeCloseAction? I know it's long, but it's OK, I think.
There was a problem hiding this comment.
Thanks for the suggestion - verbose but better than TransportShardCloseAction
bleskes
approved these changes
Dec 5, 2018
| import org.elasticsearch.threadpool.ThreadPool; | ||
| import org.elasticsearch.transport.TransportService; | ||
|
|
||
| public class TransportShardCloseAction extends TransportReplicationAction<ShardCloseRequest, ShardCloseRequest, ReplicationResponse> { |
There was a problem hiding this comment.
TransportVerifyShardBeforeCloseAction? I know it's long, but it's OK, I think.
| import org.elasticsearch.action.support.replication.ReplicationRequest; | ||
| import org.elasticsearch.index.shard.ShardId; | ||
|
|
||
| public class ShardCloseRequest extends ReplicationRequest<ShardCloseRequest> { |
There was a problem hiding this comment.
can we just inline this in the transport action file? I don't see the need for another file.
| final IndicesService indicesService, final ThreadPool threadPool, final ShardStateAction stateAction, | ||
| final ActionFilters actionFilters, final IndexNameExpressionResolver indexNameExpressionResolver) { | ||
| super(settings, NAME, transportService, clusterService, indicesService, threadPool, stateAction, | ||
| actionFilters, indexNameExpressionResolver, ShardCloseRequest::new, ShardCloseRequest::new, ThreadPool.Names.GENERIC); |
There was a problem hiding this comment.
I think we want a management thread pool here?
| + "] mismatches maximum sequence number [" + maxSeqNo + "] on index shard " + shardId); | ||
| } | ||
| indexShard.flush(new FlushRequest()); | ||
| logger.debug("shard {} is ready for closing", shardId); |
There was a problem hiding this comment.
can we put the shardId first in the log line so it will look like [index][0] shard is ready for closing ?
tlrx
force-pushed
the
add-transport-shard-close-action
branch
from
c5a0dff
to
d3e786d
Compare
tlrx
force-pushed
the
add-transport-shard-close-action
branch
from
d3e786d
to
feac528
Compare
|
Thanks @bleskes |
tlrx
added a commit
that referenced
this pull request
Dec 13, 2018
The commit changes how indices are closed in the MetaDataIndexStateService. It now uses a 3 steps process where writes are blocked on indices to be closed, then some verifications are done on shards using the TransportVerifyShardBeforeCloseAction added in #36249, and finally indices states are moved to CLOSE and their routing tables removed. The closing process also takes care of using the pre-7.0 way to close indices if the cluster contains mixed version of nodes and a node does not support the TransportVerifyShardBeforeCloseAction. It also closes unassigned indices. Related to #33888
tlrx
added a commit
that referenced
this pull request
Jan 14, 2019
This commit backports to 6.x of the Close Index API refactoring. It cherry-picks the following commits from master: 3ca885e [Close Index API] Add TransportShardCloseAction for pre-closing verifications (#36249) 8e5dd20 [Close Index API] Refactor MetaDataIndexStateService (#36354) 7372529 [Tests] Reduce randomization in CloseWhileRelocatingShardsIT (#36694) 103c4d4 [Close Index API] Mark unavailable shard copy as stale during verification (#36755) 1959388 [Close Index API] Propagate tasks ids between Freeze, Close and Verify(#36630) e149b08 [Close Index API] Add unique UUID to ClusterBlock (#36775) dc371ef [Tests] Fix ReopenWhileClosingIT with correct min num shards The following two commits were needed to adapt the change to 6.x: ef6ae69 [Close Index API] Adapt MetaDataIndexStateServiceTests after merge 21b7653 [Tests] Adapt CloseIndexIT tests for 6.x Related to #33888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this pull request will be merged in the
close-index-api-refactoringbranchThis pull request adds the
TransportShardCloseActionwhich is a transport replication action that acquires all index shard permits for its execution. This action will be used in the future by theMetaDataIndexStateServicein a new index closing process, where we need to execute some sanity checks before closing an index.The action executes the following verifications on the primary and replicas:
When the verifications are done and successful, the shard is flushed.
Once this pull request is merged, a follow up pull request will change the
MetaDataIndexStateServiceto make use of this new transport action.