Rename seq# powered optimistic concurrency control parameters to ifSeqNo/ifPrimaryTerm #36757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleskes
added
>enhancement
:Distributed/CRUD
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Dec 18, 2018
| return this; | ||
| } | ||
|
|
||
| public long ifSeqNoMatch() { | ||
| return ifSeqNoMatch; | ||
| public long ifSeqNo() { |
There was a problem hiding this comment.
can you add javadocs to the new getters and setters in IndexRequest and DeleteRequest?
|
run default distro tests |
|
run gradle build tests 1 |
|
run gradle build tests 1 |
|
/cc @elastic/es-clients |
Mpdreamz
approved these changes
Dec 18, 2018
bleskes
added a commit
that referenced
this pull request
Dec 18, 2018
…qNo/ifPrimaryTerm (#36757) This PR renames the parameters previously introduce to the following: ### URL Parameters ``` PUT twitter/_doc/1?if_seq_no=501&if_primary_term=1 { "user" : "kimchy", "post_date" : "2009-11-15T14:12:12", "message" : "trying out Elasticsearch" } DELETE twitter/_doc/1?if_seq_no=501&if_primary_term=1 ``` ### Bulk API ``` POST _bulk { "index" : { "_index" : "test", "_type" : "_doc", "_id" : "1", "if_seq_no": 501, "if_primary_term": 1 } } { "field1" : "value1" } { "delete" : { "_index" : "test", "_type" : "_doc", "_id" : "2", "if_seq_no": 501, "if_primary_term": 1 } } ``` ### Java API ``` IndexRequest.ifSeqNo(long seqNo) IndexRequest.ifPrimaryTerm(long primaryTerm) DeleteRequest.ifSeqNo(long seqNo) DeleteRequest.ifPrimaryTerm(long primaryTerm) ``` Relates #36148 Relates #10708
seut
added a commit
to crate/crate
that referenced
this pull request
Oct 25, 2019
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Oct 25, 2019
Backport of elastic/elasticsearch#36757. (cherry picked from commit 4810705)
mergify bot
pushed a commit
to crate/crate
that referenced
this pull request
Oct 25, 2019
Backport of elastic/elasticsearch#36757. (cherry picked from commit 4810705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the parameters previously introduce to the following:
URL Parameters
Bulk API
Java API
Relates #36148
Relates #10708