Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate reference to _type in lookup queries #37016

Merged
merged 16 commits into from
Jan 9, 2019
Merged

Deprecate reference to _type in lookup queries #37016

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8e892f5
Deprecate reference to _type in lookup queries
mayya-sharipova Dec 24, 2018
d7b0cd8
Some additional refactors and bug fixes.
jtibshirani Jan 3, 2019
986930e
Add Javadoc to deprecated methods to suggest alternatives.
jtibshirani Jan 7, 2019
96370d7
Switch back to using an ids query in RandomQueryBuilder.
jtibshirani Jan 7, 2019
932e250
Avoid introducing a special case in TermsLookup#hashCode.
jtibshirani Jan 7, 2019
6678b83
Add some clarifying comments.
jtibshirani Jan 7, 2019
e176101
Prefer to use Strings.EMPTY_ARRAY.
jtibshirani Jan 7, 2019
7a6100a
Give a clear error message when typeless terms lookup queries are use…
jtibshirani Jan 7, 2019
12f5eaf
Minor spacing issue.
jtibshirani Jan 7, 2019
f3031ba
Test terms lookup serialization to 6.x nodes.
jtibshirani Jan 7, 2019
c9f48a3
Make sure GeoShapeQueryBuilderTests covers typeless queries.
jtibshirani Jan 7, 2019
806e957
Simplify the handling around null types for more_like_this queries.
jtibshirani Jan 7, 2019
8324f5f
Merge remote-tracking branch 'upstream/master' into deprecate-types-i…
jtibshirani Jan 7, 2019
13c4854
Small refactors in response to review comments.
jtibshirani Jan 8, 2019
0bdbd71
Fix an outdated message in GeoShapeQueryBuilderTests.
jtibshirani Jan 8, 2019
61ad78d
Merge remote-tracking branch 'upstream/master' into deprecate-types-i…
jtibshirani Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions server/src/test/java/org/elasticsearch/index/query/RandomQueryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

import static org.elasticsearch.test.AbstractBuilderTestCase.STRING_ALIAS_FIELD_NAME;
import static org.elasticsearch.test.AbstractBuilderTestCase.STRING_FIELD_NAME;
import static org.elasticsearch.test.ESTestCase.randomAlphaOfLength;
import static org.elasticsearch.test.ESTestCase.randomFrom;

/**
Expand All @@ -48,7 +47,9 @@ public static QueryBuilder createQuery(Random r) {
case 1:
return new TermQueryBuilderTests().createTestQueryBuilder();
case 2:
return new ExistsQueryBuilder(randomAlphaOfLength(5));
// We make sure this query has no types to avoid deprecation warnings in the
// tests that use this method.
return new IdsQueryBuilderTests().createTestQueryBuilder().types(new String[0]);
cbuescher marked this conversation as resolved.
Show resolved Hide resolved
case 3:
return createMultiTermQuery(r);
default:
Expand Down