Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expired token message in Exception header #37196

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@jkakavas
Copy link
Contributor

commented Jan 7, 2019

We're adding a WWW-Authenticate header to indicate the token is
expired. This commit fixes the error message we return as part of
this.

Resolves elastic/kibana#27919

Fix expired token message in Exception header
We're adding a WWW-Authenticate header to indicate the token is
expired. This commit fixes the error message we return as part of
this.
@elasticmachine

This comment has been minimized.

Copy link

commented Jan 7, 2019

@jaymode
Copy link
Member

left a comment

I don't think this is right. See https://tools.ietf.org/html/rfc6750#section-3.1. invalid_token is the proper response for an expired token

@jkakavas

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

True ! Thanks for keeping me honest here, I failed to check the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.