Docs be explicit on how to turn off deprecated auditing #37316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>docs
|
Pinging @elastic/es-security |
|
There were some formatting issues, so I added a commit. |
lcawl
reviewed
Jan 10, 2019
| PUT /_cluster/settings | ||
| { | ||
| "persistent": { | ||
| "logger.org.elasticsearch.xpack.security.audit.logfile.DeprecatedLoggingAuditTrail": "off" |
There was a problem hiding this comment.
Should this setting be added to the list in https://www.elastic.co/guide/en/elasticsearch/reference/master/auditing-settings.html?
There was a problem hiding this comment.
No, this is just configuring the logger via the dynamic settings API, as detailed in https://www.elastic.co/guide/en/elasticsearch/reference/current/logging.html#configuring-logging-levels .
jaymode
approved these changes
Jan 11, 2019
|
run gradle build build tests 2 |
|
test this please |
ACK, Thanks Lisa! |
|
run gradle build tests 1 |
albertzaharovits
added a commit
that referenced
this pull request
Jan 15, 2019
Just be explicit about turning off the deprecated audit log appender because we really want people to turn it off.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 15, 2019
* elastic/master: Docs be explicit on how to turn off deprecated auditing (elastic#37316) Fix line length for monitor and remove suppressions (elastic#37456) Fix IndexShardTestCase.recoverReplica(IndexShard, IndexShard, boolean) (elastic#37414) Update the Flush API documentation (elastic#33551) [TEST] Muted testDifferentRolesMaintainPathOnRestart Remove dead code from ShardSearchStats (elastic#37421) Simplify testSendSnapshotSendsOps (elastic#37445) SQL: Fix issue with field names containing "." (elastic#37364) Restore lost @Inject annotation (elastic#37452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just be explicit about turning off the deprecated audit log appender because we really want people to turn it off.