Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore lost @Inject annotation #37452

Merged

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jan 15, 2019

The Inject Annotation was removed from IndicesClusterStateService as
part of reformatting in e11a32e, but this causes CreationException on
cluster startup.

The Inject Annotation was removed from IndicesClusterStateService as
part of reformatting in e11a32e, but this caused CreationException on
cluster startup.
@tvernum tvernum added v7.0.0 :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. labels Jan 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@tvernum
Copy link
Contributor Author

tvernum commented Jan 15, 2019

@jasontedor I'm going to merge this to fix the build.
I've raised it in a PR so it's easier to keep track of, in case you wanted to fix it in a different way.

@tvernum tvernum merged commit b97245c into elastic:master Jan 15, 2019
dnhatn pushed a commit that referenced this pull request Jan 15, 2019
The Inject Annotation was removed from IndicesClusterStateService as
part of reformatting in e11a32e, but this causes CreationException on
cluster startup.
@dnhatn dnhatn added the v6.7.0 label Jan 15, 2019
@dnhatn
Copy link
Member

dnhatn commented Jan 15, 2019

I have backported this into 6.x.

@jasontedor
Copy link
Member

Thanks @tvernum and @dnhatn, and sorry for the mistake.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 15, 2019
* elastic/master:
  Docs be explicit on how to turn off deprecated auditing (elastic#37316)
  Fix line length for monitor and remove suppressions (elastic#37456)
  Fix IndexShardTestCase.recoverReplica(IndexShard, IndexShard, boolean) (elastic#37414)
  Update the Flush API documentation (elastic#33551)
  [TEST] Muted testDifferentRolesMaintainPathOnRestart
  Remove dead code from ShardSearchStats (elastic#37421)
  Simplify testSendSnapshotSendsOps (elastic#37445)
  SQL: Fix issue with field names containing "." (elastic#37364)
  Restore lost @Inject annotation (elastic#37452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >non-issue v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants