Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove index audit output type #37707

Merged
merged 14 commits into from Jan 24, 2019

Conversation

Projects
None yet
5 participants
@albertzaharovits
Copy link
Contributor

commented Jan 22, 2019

Supersedes #37301

This PR removes the Index Audit Output type, following its deprecation in 6.7 by #37671 . It also adds the migration notice (settings notice).

Closes #29881

albertzaharovits added some commits Jan 22, 2019

WIP
@elasticmachine

This comment has been minimized.

Copy link

commented Jan 22, 2019

@albertzaharovits albertzaharovits requested review from jaymode and lcawl Jan 22, 2019

@jaymode
Copy link
Member

left a comment

nice stats. I left some comments

These settings enabled and configured the audit index output type. This output
type has been removed because it was unreliable in certain scenarios and this
could have lead to dropping audit events while the operations on the system
were allowed to continue as usual. This is a terrible failure state for an

This comment has been minimized.

Copy link
@jaymode

jaymode Jan 22, 2019

Member

Can we leave out This is a terrible failure state for an audit system which brought about its demise. ?

information, but it uses the older (pre-6.5.0) formatting style.
If the backwards compatible format is not required, it should be disabled.
To do that, change its logger level to `off` in the `log4j2.properties` file.
For backwards compatibility reasons, a `<clustername>_access.log` file is also

This comment has been minimized.

Copy link
@jaymode

jaymode Jan 22, 2019

Member

These are master docs, so I think this doesn't apply anymore?

This comment has been minimized.

Copy link
@albertzaharovits

albertzaharovits Jan 22, 2019

Author Contributor

You're right 🙂 At first, this made me believe I still had a PR to do to remove the bwc audit format, that's how much I trust our docs!

Show resolved Hide resolved x-pack/docs/en/security/auditing/overview.asciidoc Outdated
Show resolved Hide resolved x-pack/docs/en/security/auditing/overview.asciidoc Outdated
Show resolved Hide resolved ...in/security/src/main/java/org/elasticsearch/xpack/security/Security.java Outdated
Show resolved Hide resolved ...in/security/src/main/java/org/elasticsearch/xpack/security/Security.java

jaymode and others added some commits Jan 22, 2019

Apply suggestions from code Jay's review
Co-Authored-By: albertzaharovits <albert.zaharovits@gmail.com>
Update x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/s…
…ecurity/Security.java

Co-Authored-By: albertzaharovits <albert.zaharovits@gmail.com>
@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

nice stats. I left some comments

++ 😀

Thanks @jaymode ! I've addressed your comments.

@jaymode
Copy link
Member

left a comment

I left two minor comments. Otherwise LGTM

albertzaharovits added some commits Jan 22, 2019

@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

@elasticmachine run elasticsearch-ci/1

@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

@elasticmachine run elasticsearch-ci/2

@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

18:58:42 FAILURE: Build failed with an exception.
18:58:42
18:58:42 * Where:
18:58:42 Build file '/tmp/junit14158968466601980319/build.gradle' line: 48
18:58:42
18:58:42 * What went wrong:
18:58:42 A problem occurred evaluating root project 'junit14158968466601980319'.
18:58:42 > Could not get unknown property 'unitTest' for root project 'junit14158968466601980319' of type org.gradle.api.Project.

@elasticmachine run elasticsearch-ci/1

@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

@tvernum
Copy link
Contributor

left a comment

LGTM.
We could probably do a followup to simplify/remove AuditTrail etc, but that's not needed here.

@albertzaharovits albertzaharovits merged commit b6936e3 into elastic:master Jan 24, 2019

7 checks passed

elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@albertzaharovits albertzaharovits deleted the albertzaharovits:remove_audit_index branch Jan 24, 2019

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 24, 2019

Merge remote-tracking branch 'elastic/master' into sync-retention-leases
* elastic/master:
  Optimize warning header de-duplication (elastic#37725)
  Bubble exceptions up in ClusterApplierService (elastic#37729)
  SQL: Improve handling of invalid args for PERCENTILE/PERCENTILE_RANK (elastic#37803)
  Remove unused ThreadBarrier class (elastic#37666)
  Add built-in user and role for code plugin (elastic#37030)
  Consolidate testclusters tests into a single project (elastic#37362)
  Fix docs for MappingUpdatedAction
  SQL: Introduce SQL DATE data type (elastic#37693)
  disabling bwc test while backporting elastic#37639
  Mute ClusterDisruptionIT testAckedIndexing
  Set acking timeout to 0 on dynamic mapping update (elastic#31140)
  Remove index audit output type (elastic#37707)
  Mute FollowerFailOverIT testReadRequestsReturnsLatestMappingVersion
  [ML] Increase close job timeout and lower the max number (elastic#37770)
  Remove Custom Listeners from SnapshotsService (elastic#37629)
  Use m_m_nodes from Zen1 master for Zen2 bootstrap (elastic#37701)
  Fix index filtering in follow info api. (elastic#37752)
  Use project dependency instead of substitutions for distributions (elastic#37730)
  Update authenticate to allow unknown fields (elastic#37713)
  Deprecate HLRC EmptyResponse used by security (elastic#37540)

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.