New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronization in LocalCheckpointTracker#contains #38755

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@dnhatn
Copy link
Contributor

dnhatn commented Feb 11, 2019

While investigating #38633, I realize that we are accessing a CountedBitSet in LocalCheckpointTracker#contains without proper synchronization.

Relates #33871

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 11, 2019

@dnhatn dnhatn added the v6.6.1 label Feb 11, 2019

@dnhatn

This comment has been minimized.

Copy link
Contributor Author

dnhatn commented Feb 12, 2019

Thanks @ywelsch

@dnhatn dnhatn merged commit 90e6fb0 into elastic:master Feb 12, 2019

6 of 7 checks passed

elasticsearch-ci/packaging-sample Build triggered for merge commit.
Details
CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details

@dnhatn dnhatn deleted the dnhatn:fix-checkpoint-tracker-contains branch Feb 12, 2019

dnhatn added a commit that referenced this pull request Feb 12, 2019

Fix synchronization in LocalCheckpointTracker#contains (#38755)
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains`
without proper synchronization.

Relates #33871

dnhatn added a commit that referenced this pull request Feb 12, 2019

Fix synchronization in LocalCheckpointTracker#contains (#38755)
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains`
without proper synchronization.

Relates #33871

dnhatn added a commit that referenced this pull request Feb 12, 2019

Fix synchronization in LocalCheckpointTracker#contains (#38755)
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains`
without proper synchronization.

Relates #33871

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 13, 2019

Merge branch 'master' into soft-delete-policy-off-by-one
* master:
  Remove _type term filters from cluster alert watches (elastic#38819)
  Adjust log and unmute testFailOverOnFollower (elastic#38762)
  Fix line separators in JSON logging tests (elastic#38771)
  Fix synchronization in LocalCheckpointTracker#contains (elastic#38755)
  muted test
  Remove TLSv1.2 pinning in ssl reload tests (elastic#38651)
  Don't fail init script if `/proc/.../max_map_count` absent (elastic#35933)
  Format Watcher.status.lastChecked and lastMetCondition (elastic#38626)
  SQL: Implement `::` cast operator (elastic#38774)
  Ignore failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment